Re: [PATCH 59/78] mtip32xx: remove the call to fsync_bdev on removal

cleanup updating the size of block devices v3 · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 04/78] sd: update the bdev size in sd_revalidate_disk · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 01/78] block: remove the call to __invalidate_device in check_disk_size_change · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 03/78] nvme: let set_capacity_revalidate_and_notify update the bdev size · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 13/78] pktcdvd: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 15/78] drbd: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 16/78] rbd: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 19/78] dm-raid: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 18/78] zram: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 17/78] rnbd: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 23/78] block: unexport revalidate_disk_size · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 20/78] md: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 25/78] block: don't call into the driver for BLKFLSBUF · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 30/78] block: don't call into the driver for BLKROSET · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 30/78] block: don't call into the driver for BLKROSET · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 29/78] dasd: implement ->set_read_only to hook into BLKROSET processing · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 33/78] block: remove __blkdev_driver_ioctl · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 33/78] block: remove __blkdev_driver_ioctl · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 35/78] block: cleanup del_gendisk a bit · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 46/78] ide: switch to __register_blkdev for command set probing · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 48/78] amiflop: use separate gendisks for Amiga vs MS-DOS mode · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 47/78] floppy: use a separate gendisk for each media format · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 50/78] z2ram: reindent · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 51/78] z2ram: use separate gendisk for the different modes · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 55/78] block: change the hash used for looking up block devices · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 55/78] block: change the hash used for looking up block devices · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 56/78] init: refactor name_to_dev_t · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 56/78] init: refactor name_to_dev_t · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 57/78] init: refactor devt_from_partuuid · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 57/78] init: refactor devt_from_partuuid · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 58/78] init: cleanup match_dev_by_uuid and match_dev_by_label · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 58/78] init: cleanup match_dev_by_uuid and match_dev_by_label · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 61/78] zram: do not call set_blocksize · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 61/78] zram: do not call set_blocksize · Hannes Reinecke <hare@suse.de> · 2020-11-20
Re: [PATCH 61/78] zram: do not call set_blocksize · Minchan Kim <minchan@kernel.org> · 2020-11-26
[PATCH 59/78] mtip32xx: remove the call to fsync_bdev on removal · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 59/78] mtip32xx: remove the call to fsync_bdev on removal · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 64/78] dm: simplify flush_bio initialization in __send_empty_flush · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 64/78] dm: simplify flush_bio initialization in __send_empty_flush · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 69/78] block: remove the nr_sects field in struct hd_struct · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 69/78] block: remove the nr_sects field in struct hd_struct · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 70/78] block: replace bd_mutex with a per-gendisk mutex · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 70/78] block: replace bd_mutex with a per-gendisk mutex · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 78/78] block: remove i_bdev · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 77/78] fs: simplify the get_super_thawed interface · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 74/78] block: merge struct block_device and struct hd_struct · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 74/78] block: merge struct block_device and struct hd_struct · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 75/78] block: stop using bdget_disk for partition 0 · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 71/78] block: add a bdev_kobj helper · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 71/78] block: add a bdev_kobj helper · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 60/78] zram: remove the claim mechanism · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 60/78] zram: remove the claim mechanism · Hannes Reinecke <hare@suse.de> · 2020-11-20
Re: [PATCH 60/78] zram: remove the claim mechanism · Minchan Kim <minchan@kernel.org> · 2020-11-26
Re: [PATCH 60/78] zram: remove the claim mechanism · Christoph Hellwig <hch@lst.de> · 2020-11-26
[PATCH 67/78] block: simplify the block device claiming interface · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 67/78] block: simplify the block device claiming interface · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 68/78] block: remove ->bd_contains · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 68/78] block: remove ->bd_contains · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 76/78] filemap: use ->f_mapping over ->i_mapping consistently · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 73/78] block: use put_device in put_disk · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 73/78] block: use put_device in put_disk · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 72/78] block: use disk_part_iter_exit in disk_part_iter_next · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 72/78] block: use disk_part_iter_exit in disk_part_iter_next · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 66/78] block: keep a block_device reference for each hd_struct · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 66/78] block: keep a block_device reference for each hd_struct · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 65/78] dm: remove the block_device reference in struct mapped_device · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 65/78] dm: remove the block_device reference in struct mapped_device · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 63/78] bcache: remove a superflous lookup_bdev all · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 62/78] loop: do not call set_blocksize · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 62/78] loop: do not call set_blocksize · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 53/78] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 53/78] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 41/78] swim: don't call blk_register_region · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 54/78] block: remove a duplicate __disk_get_part prototype · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 54/78] block: remove a duplicate __disk_get_part prototype · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 52/78] block: switch gendisk lookup to a simple xarray · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 49/78] ataflop: use a separate gendisk for each media format · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 38/78] block: rework requesting modules for unclaimed devices · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 37/78] block: split block_class_lock · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 45/78] md: use __register_blkdev to allocate devices on demand · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 40/78] ide: remove ide_{,un}register_region · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 42/78] sd: use __register_blkdev to avoid a modprobe for an unregistered dev_t · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 44/78] loop: use __register_blkdev to allocate devices on demand · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 43/78] brd: use __register_blkdev to allocate devices on demand · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 36/78] block: open code kobj_map into in block/genhd.c · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 39/78] block: add an optional probe callback to major_names · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 34/78] block: propagate BLKROSET to all partitions · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 34/78] block: propagate BLKROSET to all partitions · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 31/78] loop: use set_disk_ro · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 31/78] loop: use set_disk_ro · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 32/78] block: remove set_device_ro · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 32/78] block: remove set_device_ro · Hannes Reinecke <hare@suse.de> · 2020-11-20
[PATCH 27/78] rbd: implement ->set_read_only to hook into BLKROSET processing · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 26/78] block: add a new set_read_only method · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 28/78] md: implement ->set_read_only to hook into BLKROSET processing · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 28/78] md: implement ->set_read_only to hook into BLKROSET processing · Song Liu <song@kernel.org> · 2020-11-16
[PATCH 24/78] mtd_blkdevs: don't override BLKFLSBUF · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 21/78] md: remove a spurious call to revalidate_disk_size in update_size · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 22/78] virtio-blk: remove a spurious call to revalidate_disk_size · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 08/78] nbd: refactor size updates · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 09/78] nbd: validate the block size in nbd_set_size · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 11/78] aoe: don't call set_capacity from irq context · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 07/78] nbd: move the task_recv check into nbd_size_update · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 10/78] nbd: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 14/78] nvme: use set_capacity_and_notify in nvme_set_queue_dying · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 12/78] dm: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: [PATCH 12/78] dm: use set_capacity_and_notify · Mike Snitzer <hidden> · 2021-02-12
Re: [PATCH 12/78] dm: use set_capacity_and_notify · Christoph Hellwig <hch@lst.de> · 2021-02-16
[PATCH 06/78] nbd: remove the call to set_blocksize · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 05/78] block: remove the update_bdev parameter to set_capacity_revalidate_and_notify · Christoph Hellwig <hch@lst.de> · 2020-11-16
[PATCH 02/78] loop: let set_capacity_revalidate_and_notify update the bdev size · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: cleanup updating the size of block devices v3 · Christoph Hellwig <hch@lst.de> · 2020-11-16
Re: cleanup updating the size of block devices v3 · Jens Axboe <axboe@kernel.dk> · 2020-11-16

From: Hannes Reinecke <hare@suse.de>
Date: 2020-11-20 07:35:58
Also in: ceph-devel, dm-devel, linux-block, linux-fsdevel, linux-nvme, linux-scsi, xen-devel

On 11/16/20 3:57 PM, Christoph Hellwig wrote:

del_gendisk already calls fsync_bdev for every partition, no need
to do this twice.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
  drivers/block/mtip32xx/mtip32xx.c | 15 ---------------
  drivers/block/mtip32xx/mtip32xx.h |  2 --
  2 files changed, 17 deletions(-)

Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help