Thread (4 messages) 4 messages, 2 authors, 2020-10-05

Re: [PATCH 1/2] [md/bitmap] md_bitmap_read_sb use wrong bitmap blocks

From: Song Liu <song@kernel.org>
Date: 2020-10-05 07:44:14

On Sat, Oct 3, 2020 at 9:26 AM heming.zhao@suse.com
[off-list ref] wrote:
very sorry for my mistake.

the patch should be change from:
-               sector_div(bm_blocks,
+               DIV_ROUND_UP_SECTOR_T(bm_blocks,
                           bitmap->mddev->bitmap_info.chunksize >> 9);
to
-               sector_div(bm_blocks,
-                          bitmap->mddev->bitmap_info.chunksize >> 9);
+               bm_blocks = DIV_ROUND_UP_SECTOR_T(bm_blocks,
+                          (bitmap->mddev->bitmap_info.chunksize >> 9));
If my patch would be accepted, I will send v2 patch including above lines.
Please send v2 of the patch. Please also CC Guoqing in v2.

Thanks,
Song
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help