On Thu, 2020-10-29 at 18:01 -0700, James Bottomley wrote:

On Thu, 2020-10-29 at 17:11 -0700, Joe Perches wrote:

quoted

This file still does not have an SPDX line.  What should it be?

It's old style MIT with a slight variation:

https://fedoraproject.org/wiki/Licensing:MIT#Old_Style

Yes, it's quite similar.
But ", and sell" does not exist in this variant.

So I believe its use of MODULE_LICENSE("GPL") is not correct and
that MODULE_LICENSE("GPL and additional rights") might be the best
available option.

MIT Old style:

Permission to use, copy, modify, distribute, and sell this software and its
documentation for any purpose is hereby granted without fee, provided that
the above copyright notice appear in all copies and that both that
copyright notice and this permission notice appear in supporting
documentation.  No representations are made about the suitability of this
software for any purpose.  It is provided "as is" without express or
implied warranty.

License in the file:

 * Permission to use, copy, modify, and distribute this software and its
 * documentation for any purpose and without fee is hereby granted, provided
 * that the above copyright notice appear in all copies and that both that
 * copyright notice and this permission notice appear in supporting
 * documentation.  This software is provided "as is" without express or
 * implied warranty.