Re: WARNING in md_ioctl
From: Dae R. Jeong <hidden>
Date: 2020-10-22 00:24:58
Also in:
lkml
From: Dae R. Jeong <hidden>
Date: 2020-10-22 00:24:58
Also in:
lkml
quoted
quoted
diff --git i/drivers/md/md.c w/drivers/md/md.c index 6072782070230..49442a3f4605b 100644 --- i/drivers/md/md.c +++ w/drivers/md/md.c@@ -7591,8 +7591,10 @@ static int md_ioctl(struct block_device *bdev,fmode_t mode, err = -EBUSY; goto out; } - WARN_ON_ONCE(test_bit(MD_CLOSING, &mddev->flags)); - set_bit(MD_CLOSING, &mddev->flags); + if (test_and_set_bit(MD_CLOSING, &mddev->flags)) { + err = -EBUSY; + goto out; + } did_set_md_closing = true; mutex_unlock(&mddev->open_mutex); sync_blockdev(bdev);Good catch! The fix looks good. Would you like to submit a patch for it?
Sure. I will send a patch soon. Best regards, Dae R. Jeong.