Thread (2 messages) 2 messages, 2 authors, 2020-10-14

Re: [PATCH 3/4] mdmonitor: set small delay once

From: Nix <hidden>
Date: 2020-09-16 00:52:01

On 9 Sep 2020, Mariusz Tkaczyk uttered the following:
quoted hunk
+				/*
+				 * If mdmonitor is awaken by event, set small delay once
+				 * to deal with udev and mdadm.
+				 */
+				if (wait_result != 0) {
+					if (c->delay > 5)
+						delay_for_event = 5;
+				} else
+					delay_for_event = c->delay;
This is racy: if any delay is needed, any finite delay value will
now and then be too short.

I think this should be fixed by arranging for mdmonitor to be signalled
when udev or whatever has finished whatever it's doing. (udev has lots
of ways it could be asked to do that.)
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help