Re: [PATCH v2 01/10] md/raid5: make sure stripe_size as power of two
From: Song Liu <song@kernel.org>
Date: 2020-08-21 00:46:45
On Thu, Aug 20, 2020 at 6:21 AM Yufen Yu [off-list ref] wrote:
Commit 3b5408b98e4d ("md/raid5: support config stripe_size by sysfs
entry") make stripe_size as a configurable value. It just requires
stripe_size as multiple of 4KB.
In fact, we should make sure stripe_size as power of two. Otherwise,
stripe_shift which is the result of ilog2 can not represent the real
stripe_size. Then, stripe_hash() and stripe_hash_locks_hash() may
get unexpected value.
Fixes: 3b5408b98e4d ("md/raid5: support config stripe_size by sysfs entry")
Signed-off-by: Yufen Yu <redacted>Applied to md-fixes. Thanks!