Re: [PATCH V2 1/3] Move codes related with submitting discard bio into one function
From: Guoqing Jiang <hidden>
Date: 2020-07-28 08:21:54
Hi Xiao, Better to add a prefix before subject like "md" ...", the same to other patches. On 7/28/20 9:18 AM, Xiao Ni wrote:
quoted hunk ↗ jump to hunk
These codes can be used in raid10. So we can move these codes into md.c. raid0 and raid10 can share these codes. Reviewed-by: Coly Li <redacted> Signed-off-by: Xiao Ni <redacted> --- drivers/md/md.c | 22 ++++++++++++++++++++++ drivers/md/md.h | 3 +++ drivers/md/raid0.c | 15 ++------------- 3 files changed, 27 insertions(+), 13 deletions(-)diff --git a/drivers/md/md.c b/drivers/md/md.c index 07e5b67..2b8f654 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c@@ -8559,6 +8559,28 @@ void md_write_end(struct mddev *mddev) EXPORT_SYMBOL(md_write_end);
Could you add comment before the function to inform it is used by raid0 and raid10?
+void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev, + struct bio *bio, + sector_t dev_start, sector_t dev_end)
Thanks, Guoqing