Thread (29 messages) 29 messages, 6 authors, 2020-07-02

Re: [PATCH 16/20] block: move ->make_request_fn to struct block_device_operations

From: Dan Williams <hidden>
Date: 2020-07-01 16:08:32
Also in: dm-devel, linux-bcache, linux-m68k, linux-nvme, linux-s390, linuxppc-dev, lkml, nvdimm

On Wed, Jul 1, 2020 at 2:01 AM Christoph Hellwig [off-list ref] wrote:
The make_request_fn is a little weird in that it sits directly in
struct request_queue instead of an operation vector.  Replace it with
a block_device_operations method called submit_bio (which describes much
better what it does).  Also remove the request_queue argument to it, as
the queue can be derived pretty trivially from the bio.

Signed-off-by: Christoph Hellwig <redacted>
---
[..]
 drivers/nvdimm/blk.c                          |  5 +-
 drivers/nvdimm/btt.c                          |  5 +-
 drivers/nvdimm/pmem.c                         |  5 +-
For drivers/nvdimm

Acked-by: Dan Williams <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help