Thread (52 messages) 52 messages, 8 authors, 2024-09-04

Re: [PATCH 06/23] md: remove the autoscan partition re-read

flat view

From: NeilBrown <neil@brown.name>
Date: 2020-07-15 23:34:16
Also in: linux-fsdevel, lkml

On Tue, Jul 14 2020, Christoph Hellwig wrote:
devfs is long gone, and autoscan works just fine without this these days.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Song Liu <song@kernel.org>
Happy to see this go!

Reviewed-by: NeilBrown <redacted>

Thanks,
NeilBrown

quoted hunk ↗ jump to hunk
---
 drivers/md/md-autodetect.c | 10 ----------
 1 file changed, 10 deletions(-)
diff --git a/drivers/md/md-autodetect.c b/drivers/md/md-autodetect.c
index 0eb746211ed53c..6bc9b734eee6ff 100644
--- a/drivers/md/md-autodetect.c
+++ b/drivers/md/md-autodetect.c
@@ -240,16 +240,6 @@ static void __init md_setup_drive(void)
 			err = ksys_ioctl(fd, RUN_ARRAY, 0);
 		if (err)
 			printk(KERN_WARNING "md: starting md%d failed\n", minor);
-		else {
-			/* reread the partition table.
-			 * I (neilb) and not sure why this is needed, but I cannot
-			 * boot a kernel with devfs compiled in from partitioned md
-			 * array without it
-			 */
-			ksys_close(fd);
-			fd = ksys_open(name, 0, 0);
-			ksys_ioctl(fd, BLKRRPART, 0);
-		}
 		ksys_close(fd);
 	}
 }
-- 
2.27.0

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help