Re: [PATCH] md: improve io stats accounting
From: John Stoffel <hidden>
Date: 2020-06-02 17:32:54
From: John Stoffel <hidden>
Date: 2020-06-02 17:32:54
quoted
quoted
quoted
quoted
"Artur" == Artur Paszkiewicz [off-list ref] writes:
Artur> On 6/2/20 8:48 AM, Song Liu wrote:
quoted
quoted
+ clone = bio_clone_fast(bio, GFP_NOIO, &mddev->md_io_bs);Handle clone == NULL?
Artur> I think this should never fail - bio_alloc_bioset() guarantees that. It Artur> is used in a similar manner in raid1 and raid10. How about Artur> BUG_ON(clone == NULL)? No, use WARN_ON() instead, why would you bug the entire system for just one logical device throwing an error?