On Mon, Jan 13, 2020 at 10:17 AM Piergiorgio Sartor
[off-list ref] wrote:

On Mon, Jan 13, 2020 at 10:11:00AM -0800, Song Liu wrote:

quoted

+ dm-devel

On Sun, Jan 12, 2020 at 5:43 AM Gandalf Corvotempesta
[off-list ref] wrote:

quoted

I'm testing dm-integrity.
Simple question: when corrupted data are found, repair is done
immediately or on next scrub?

This is what I have:

[ 6727.395808] md: data-check of RAID array md0
[ 6727.528589] device-mapper: integrity: Checksum failed at sector 0xe228
[ 6727.938689] md: md0: data-check done.
[ 6749.125075] md: data-check of RAID array md0
[ 6749.664269] md: md0: data-check done.

if repair is done immediatly, would be possible to add a single log
line saying that ?
something like:
[ 6727.528589] md: md0: Repaired data at sector 0xe228

I guess this belongs to dm-integrity instead of md?

Eh, well, no.
He is asking about "md" in case the underlying
layer, dm-integrity in this case, returns an error.

This could be the case also if the HDD returns
a read error which the RAID will correct and,
if I get it right, rewrite.

I see. Thanks for the clarification.

But I guess "md" already returns where the
correction happened, isn't like that?
I recall seeing in the logs something about
it, but it was some time ago...

Right now, md_done_sync() doesn't really print any message. I think this is
easy to add. However, md check/recovery is at block granularity, so we
probably cannot print exact which sector got fixed.

Thanks,
Song