Re: [PATCH] md: md.c: Return -ENODEV when mddev is NULL in rdev_attr_show
From: Song Liu <hidden>
Date: 2019-06-06 16:41:25
Also in:
lkml
On Thu, May 23, 2019 at 7:45 PM Marcos Paulo de Souza [off-list ref] wrote:
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to
return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show.
nit: checkpatch.pl complains
WARNING: Possible unwrapped commit description (prefer a maximum 75
chars per line)
#84:
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to
I fixed this in my tree, so no need to resend.
Thanks,
Song
quoted hunk ↗ jump to hunk
Signed-off-by: Marcos Paulo de Souza <redacted> --- drivers/md/md.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/md/md.c b/drivers/md/md.c index 45ffa23fa85d..0b391e7e063b 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c@@ -3363,7 +3363,7 @@ rdev_attr_show(struct kobject *kobj, struct attribute *attr, char *page) if (!entry->show) return -EIO; if (!rdev->mddev) - return -EBUSY; + return -ENODEV; return entry->show(rdev, page); } --2.21.0