Re: [PATCH 1/3] Don't jump to compute_result state from check_result state
From: Song Liu <hidden>
Date: 2019-03-29 18:12:17
Also in:
linux-block, stable
From: Song Liu <hidden>
Date: 2019-03-29 18:12:17
Also in:
linux-block, stable
On Mar 29, 2019, at 10:51 AM, Jens Axboe [off-list ref] wrote: On 3/29/19 11:46 AM, Song Liu wrote:quoted
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index c033bfcb209e..4204a972ecf2 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c@@ -4223,26 +4223,15 @@ static void handle_parity_checks6(struct r5conf *conf, struct stripe_head *sh,case check_state_check_result: sh->check_state = check_state_idle; + if (s->failed > 1) + break;Not sure what happened here, but there's a lot of whitespace after that if statement, and the break is using 4 spaces instead of a tab. I fixed both of these up, but please review the style of patches going forward. -- Jens Axboe
Thanks Jens! I will be more careful in the future. Song