Re: [PATCH] md: Fix failed allocation of md_register_thread
From: Song Liu <hidden>
Date: 2019-03-06 16:58:19
Also in:
lkml
On Mon, Mar 4, 2019 at 2:50 PM Aditya Pakki [off-list ref] wrote:
mddev->sync_thread can be set to NULL on kzalloc failure downstream. The patch checks for such a scenario and frees allocated resources. Signed-off-by: Aditya Pakki <redacted>
This looks good. Could you please add a "Fixed:" tag? Thanks, Song
quoted hunk ↗ jump to hunk
--- drivers/md/raid10.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index abb5d382f64d..f52b4d9bcd24 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c@@ -3939,6 +3939,8 @@ static int raid10_run(struct mddev *mddev) set_bit(MD_RECOVERY_RUNNING, &mddev->recovery); mddev->sync_thread = md_register_thread(md_do_sync, mddev, "reshape"); + if (!mddev->sync_thread) + goto out_free_conf; } return 0; --2.17.1