Re: [PATCH V10 15/19] block: always define BIO_MAX_PAGES as 256

From
Ming Lei <hidden>
Date
2018-11-19 09:04:16
Also in
dm-devel, linux-bcache, linux-block, linux-btrfs, linux-ext4, linux-fsdevel, linux-mm, linux-xfs, lkml
Reply to
Omar Sandoval, 2018-11-16
On Thu, Nov 15, 2018 at 05:59:36PM -0800, Omar Sandoval wrote:
On Thu, Nov 15, 2018 at 04:53:02PM +0800, Ming Lei wrote:
quoted
Now multi-page bvec can cover CONFIG_THP_SWAP, so we don't need to
increase BIO_MAX_PAGES for it.
You mentioned to it in the cover letter, but this needs more explanation
in the commit message. Why did CONFIG_THP_SWAP require > 256? Why does
multipage bvecs remove that requirement?
CONFIG_THP_SWAP needs to split one TH page into normal pages and adds
them all to one bio. With multipage-bvec, it just takes one bvec to
hold them all.

thanks,
Ming
Thread (102 messages) 102 messages, 8 authors, last reply 2018-11-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help