Thread (16 messages) 16 messages, 5 authors, 2018-05-29

Re: [PATCH 2/6] proc: commit to genradix

From: Kent Overstreet <hidden>
Date: 2018-05-23 22:18:45
Also in: linux-security-module, lkml, selinux

On Wed, May 23, 2018 at 04:28:23AM -0700, Matthew Wilcox wrote:
On Tue, May 22, 2018 at 09:18:17PM -0400, Kent Overstreet wrote:
quoted
@@ -2140,11 +2140,12 @@ proc_map_files_readdir(struct file *file, struct dir_context *ctx)
 	struct task_struct *task;
 	struct mm_struct *mm;
 	unsigned long nr_files, pos, i;
-	struct flex_array *fa = NULL;
-	struct map_files_info info;
+	GENRADIX(struct map_files_info) fa;
 	struct map_files_info *p;
 	int ret;
 
+	genradix_init(&fa);
Could we have a DEFINE_GENRADIX(type, name) which initialises the tree?
Already exists. I kind of prefer not to use it when I don't need to though, and
stick to things that look more like normal declarations instead.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help