Thread (95 messages) 95 messages, 4 authors, 2018-01-03

Re: [PATCH v5 77/78] irqdomain: Convert to XArray

From: Marc Zyngier <hidden>
Date: 2017-12-16 10:51:05
Also in: linux-f2fs-devel, linux-fsdevel, linux-mm, linux-usb, linux-xfs, lkml

On Fri, 15 Dec 2017 22:04:49 +0000,
Matthew Wilcox wrote:
From: Matthew Wilcox <redacted>

In a non-critical path, irqdomain wants to know how many entries are
stored in the xarray, so add xa_count().  This is a pretty straightforward
conversion; mostly just removing now-redundant locking.  The only thing
of note is just how much simpler irq_domain_fix_revmap() becomes.

Signed-off-by: Matthew Wilcox <redacted>
---
 include/linux/irqdomain.h | 10 ++++------
 include/linux/xarray.h    |  1 +
 kernel/irq/irqdomain.c    | 39 ++++++++++-----------------------------
 lib/xarray.c              | 25 +++++++++++++++++++++++++
 4 files changed, 40 insertions(+), 35 deletions(-)
I certainly welcome the simplification this provides.

As for xa_count(), I'm trying to convince myself that the code under
CONFIG_IRQ_DOMAIN_DEBUG is now completely superseded by
CONFIG_GENERIC_IRQ_DEBUGFS, and that there would be more value in
getting rid of it rather than keeping it on life support.

Until then, the 1:1 replacement is good enough.

Acked-by: Marc Zyngier <redacted>

	M.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help