Re: [PATCH 1/2] md: release allocated bitset sync_set
From: Shaohua Li <shli@kernel.org>
Date: 2017-11-09 23:32:06
On Wed, Nov 08, 2017 at 01:44:55PM +0100, Zdenek Kabelac wrote:
Patch fixes kmemleak on md_stop() path used likely only by dm-raid wrapper. Code of md is using mddev_put() where both bitsets are released however this bitmap freeing is not shared.
what did you mean 'bitmap freeing is not shared' ? The patch doesn't handle bitmap either.
quoted hunk ↗ jump to hunk
Also set NULL to bio_set and sync_set pointers just like mddev_put is doing. Signed-off-by: Zdenek Kabelac <redacted> --- drivers/md/md.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)diff --git a/drivers/md/md.c b/drivers/md/md.c index 0ff1bbf6c90e..635ad7c38f67 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c@@ -5834,8 +5834,14 @@ void md_stop(struct mddev *mddev) * This is called from dm-raid */ __md_stop(mddev); - if (mddev->bio_set) + if (mddev->bio_set) { bioset_free(mddev->bio_set); + mddev->bio_set = NULL; + } + if (mddev->sync_set) { + bioset_free(mddev->sync_set); + mddev->sync_set = NULL; + } } EXPORT_SYMBOL_GPL(md_stop);-- 2.15.0 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html