Re: [dm-devel] [PATCH 3/4] dm: convert dm_dev_internal.count from atomic_t to refcount_t

On Fri, Nov 24, 2017 at 2:36 AM, Reshetova, Elena
[off-list ref] wrote:

quoted

On Fri, Oct 20, 2017 at 10:37:38AM +0300, Elena Reshetova wrote:

quoted

    } else if (dd->dm_dev->mode != (mode | dd->dm_dev->mode)) {
            r = upgrade_mode(dd, mode, t->md);
            if (r)
                    return r;
+           refcount_inc(&dd->count);
    }

Missing here:

        else
              refcount_inc(&dd->count);

?

Oh, yes, thanks for catching this! I think this got unnoticed so far and patch was merged, so I am going to send a followup patch now.

I pushed this fix and will send to Linus next week:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.15&id=d908af82d06cc420f9581c97c6db941cb87e4434