On 07/27/2017 09:22 AM, Mariusz Tkaczyk wrote:
GET_MISMATCH option doesn't exist for containers so sysfs_read fails if
this information is requested. Set options according to the device using
information from /proc/mdstat.
Signed-off-by: Mariusz Tkaczyk <redacted>
---
Monitor.c | 45 +++++++++++++++++++++++++++------------------
1 file changed, 27 insertions(+), 18 deletions(-)
Hi Mariusz,
Sorry for the late response, I am just back from PTO.
I know you will hate me for this, but I have one more nit:
quoted hunk ↗ jump to hunk
diff --git a/Monitor.c b/Monitor.c
index 48c451c..de470bd 100644
--- a/Monitor.c
+++ b/Monitor.c
@@ -465,6 +465,8 @@ static int check_array(struct state *st, struct mdstat_ent *mdstat,
int last_disk;
int new_array = 0;
int retval;
+ int is_container;
+ unsigned long array_only_flags = 0;
if (test)
alert("TestMessage", dev, NULL, ainfo);
[snip]
quoted hunk ↗ jump to hunk
+ if (!mse) {
+ /* duplicated array in statelist
+ * or re-created after reading mdstat
+ */
+ st->err++;
+ goto out;
+ }
+
+ is_container = mse->level == NULL;
I really find this last line super obfuscating - I had to go back and read it again to realize it wasn't just trying to set is_container and mse->level both to NULL.
Would you mind using an if statement there instead?
Thanks,
Jes