Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function

[PATCH v2 00/21] Introduce common scatterlist map function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 02/21] libiscsi: Add an internal error code · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
Re: [PATCH v2 02/21] libiscsi: Add an internal error code · Christoph Hellwig <hch@lst.de> · 2017-04-26
[PATCH v2 08/21] dm-crypt: Make use of the new sg_map helper in 4 call sites · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 05/21] drm/i915: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Christoph Hellwig <hch@lst.de> · 2017-04-26
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-26
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Christoph Hellwig <hch@lst.de> · 2017-04-27
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Jason Gunthorpe <hidden> · 2017-04-27
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Christian König <christian.koenig@amd.com> · 2017-04-26
Re: [PATCH v2 01/21] scatterlist: Introduce sg_map helper functions · Logan Gunthorpe <logang@deltatee.com> · 2017-04-26
[PATCH v2 20/21] mmc: tifm_sd: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 19/21] mmc: sdricoh_cs: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Roger Pau Monné <roger.pau@citrix.com> · 2017-04-26
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Jason Gunthorpe <hidden> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Jason Gunthorpe <hidden> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Jason Gunthorpe <hidden> · 2017-04-27
Re: [PATCH v2 15/21] xen-blkfront: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
[PATCH v2 12/21] scsi: hisi_sas, mvsas, gdth: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 10/21] RDS: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 13/21] scsi: arcmsr, ips, megaraid: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 17/21] mmc: spi: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 06/21] crypto: hifn_795x: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 21/21] memstick: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 11/21] scsi: ipr, pmcraid, isci: Make use of the new sg_map helper · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 09/21] staging: unisys: visorbus: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 18/21] mmc: tmio: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 16/21] mmc: sdhci: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 04/21] target: Make use of the new sg_map function at 16 call sites · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Herbert Xu <herbert@gondor.apana.org.au> · 2017-04-27
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-27
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Herbert Xu <herbert@gondor.apana.org.au> · 2017-04-28
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-28
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Herbert Xu <herbert@gondor.apana.org.au> · 2017-04-28
Re: [PATCH v2 07/21] crypto: shash, caam: Make use of the new sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-28
[PATCH v2 03/21] libiscsi: Make use of new the sg_map helper function · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25
[PATCH v2 14/21] scsi: libfc, csiostor: Change to sg_copy_buffer in two drivers · Logan Gunthorpe <logang@deltatee.com> · 2017-04-25

From: Logan Gunthorpe <hidden>
Date: 2017-04-28 16:54:16
Also in: dm-devel, dri-devel, intel-gfx, linux-crypto, linux-media, linux-mmc, linux-rdma, linux-scsi, lkml, netdev, nvdimm


On 28/04/17 12:30 AM, Herbert Xu wrote:

You are right.  Indeed the existing code looks buggy as they
don't take sg->offset into account when doing the kmap.  Could
you send me some patches that fix these problems first so that
they can be easily backported?

Ok, I think the only buggy one in crypto is hifn_795x. Shash and caam
both do have the sg->offset accounted for. I'll send a patch for the
buggy one shortly.

Logan

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help