Re: [PATCH 1/2] Replace snprintf with strncpy at some places to avoid truncation

Started by jes.sorensen@gmail.com on Mar 28, 2017

open the first message on its own page

Message details and related content
Xiao Ni [off-list ref] writes:
In gcc7 there are some building errors like:
directive output may be truncated writing up to 31 bytes into a region of size 24
snprintf(str, MPB_SIG_LEN, %s, mpb->sig);

It just need to copy one string to target. So use strncpy to replace it.

For this line code: snprintf(str, MPB_SIG_LEN, %s, mpb->sig);
Because mpb->sig has the content of version after magic, so
it's better to use strncpy to replace snprintf too.

Signed-off-by: Xiao Ni <redacted>
---
 super-intel.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)
Applied!

Thanks,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help