Thread (31 messages) 31 messages, 2 authors, 2017-03-23

Re: REALLY Fix bug in [md PATCH 02/15] md/raid5: simplfy delaying of writes while metadata is updated.

From: Shaohua Li <shli@kernel.org>
Date: 2017-03-23 02:22:01

On Wed, Mar 22, 2017 at 01:35:48PM +1100, Neil Brown wrote:
On Wed, Mar 22 2017, NeilBrown wrote:
quoted
Using r1_bio->sector in call_bio_endio is more
obviously-correct than bio->bi_iter.bi_sector,
though both should have the same value.

The inc_pending() call in handle_read_error() was missing.
One should always accompany a bio_inc_remaining.

Signed-off-by: NeilBrown <redacted>
---

Sorry, I left an unused variable...
NeilBrown
Sorry again - I replied to the wrong email (not a good day...)
and gave the wrong subject.
This should be
  REALLY Fix bugs in [md PATCH 10/15] md/raid1: stop using bi_phys_segment

:-(
Thanks, applied all the patches except the 'trace completion' patch.

Thanks,
Shaohua
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help