Re: [PATCH v2] blk: improve order of bio handling in generic_make_request()

From
Jens Axboe <axboe@kernel.dk>
Date
2017-03-10 04:40:31
Also in
dm-devel, linux-block, lkml
Reply to
Jens Axboe, 2017-03-10
On 03/09/2017 09:38 PM, Jens Axboe wrote:
On 03/09/2017 09:32 PM, NeilBrown wrote:
quoted
I started looking further at the improvements we can make once
generic_make_request is fixed, and realised that I had missed an
important detail in this patch.
Several places test current->bio_list, and two actually edit the list.
With this change, that cannot see the whole lists, so it could cause a
regression.

So I've revised the patch to make sure that the entire list of queued
bios remains visible, and change the relevant code to look at both
the new list and the old list.

Following that there are some patches which make the rescuer thread
optional, and then starts removing it from some easy-to-fix places.
Neil, note that the v2 patch is already in Linus tree as of earlier
today. You need to rebase the series, and if we need fixups on
top of v2, then that should be done separately and with increased
urgency.
Additionally, at least the first patch appears to be badly mangled.
The formatting is screwed up.

-- 
Jens Axboe
Thread (17 messages) 17 messages, 6 authors, last reply 2017-03-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help