RE: [PATCH 22/29] drivers, scsi: convert iscsi_task.refcount from atomic_t to refcount_t

From
Reshetova, Elena <elena.reshetova@intel.com>
Date
2017-03-09 09:26:18
Also in
linux-bcache, linux-media, linux-pci, linux-s390, linux-scsi, linux-serial, lkml, netdev
Reply to
Johannes Thumshirn, 2017-03-09
On 03/09/2017 08:18 AM, Reshetova, Elena wrote:
quoted
quoted
On Mon, Mar 06, 2017 at 04:21:09PM +0200, Elena Reshetova wrote:
quoted
refcount_t type and corresponding API should be
used instead of atomic_t when the variable is used as
a reference counter. This allows to avoid accidental
refcounter overflows that might lead to use-after-free
situations.

Signed-off-by: Elena Reshetova <elena.reshetova@intel.com>
Signed-off-by: Hans Liljestrand <redacted>
Signed-off-by: Kees Cook <redacted>
Signed-off-by: David Windsor <redacted>
This looks OK to me.

Acked-by: Chris Leech <cleech@redhat.com>
Thank you for review! Do you have a tree that can take this change?
Hi Elena,

iscsi like fcoe should go via the SCSI tree.
Thanks Johannes! Should I resend with "Acked-by" added in order for it to be picked up? 

Best Regards,
Elena.

Byte,
	Johannes

--
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
Thread (66 messages) 66 messages, 12 authors, last reply 2017-03-21
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help