On Thu, Feb 16, 2017 at 8:35 PM, Johannes Thumshirn [off-list ref] wrote:

On 02/16/2017 12:45 PM, Ming Lei wrote:

quoted

@@ -998,7 +998,8 @@ static void alloc_behind_pages(struct bio *bio, struct r1bio *r1_bio)
 {
      int i;
      struct bio_vec *bvec;
-     struct bio_vec *bvecs = kzalloc(bio->bi_vcnt * sizeof(struct bio_vec),
+     unsigned vcnt = bio_segments_all(bio);
+     struct bio_vec *bvecs = kzalloc(vcnt * sizeof(struct bio_vec),
                                      GFP_NOIO);

Maybe use kcalloc() instead of kzalloc() with a multiplication.

That doesn't belong to this patch, which just wants to remove direct
access to .bi_vcnt.


Thanks,
Ming Lei