Thread (11 messages) 11 messages, 4 authors, 2017-02-15

Re: [PATCH v2 5/5] md: fast clone bio in bio_clone_mddev()

flat view

From: Christoph Hellwig <hch@infradead.org>
Date: 2017-02-14 16:01:19
Also in: linux-block, lkml

On Tue, Feb 14, 2017 at 11:29:03PM +0800, Ming Lei wrote:
Firstly bio_clone_mddev() is used in raid normal I/O and isn't
in resync I/O path.

Secondly all the direct access to bvec table in raid happens on
resync I/O except for write behind of raid1, in which we still
use bio_clone() for allocating new bvec table.

So this patch replaces bio_clone() with bio_clone_fast()
in bio_clone_mddev().

Also kill bio_clone_mddev() and call bio_clone_fast() directly, as
suggested by Christoph Hellwig.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>

Btw, can you also tack on another patch to kill bio_alloc_mddev
to be consistent?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help