Re: [PATCH 04/18] block: simplify blk_init_allocated_queue

From
Martin K. Petersen <hidden>
Date
2017-01-26 03:02:54
Also in
dm-devel, linux-block, linux-scsi
quoted
quoted
quoted
quoted
"Christoph" == Christoph Hellwig [off-list ref] writes:
Christoph> Return an errno value instead of the passed in queue so that
Christoph> the callers don't have to keep track of two queues, and move
Christoph> the assignment of the request_fn and lock to the caller as
Christoph> passing them as argument doesn't simplify anything.  While
Christoph> we're at it also remove two pointless NULL assignments, given
Christoph> that the request structure is zeroed on allocation.

Reviewed-by: Martin K. Petersen <redacted>

-- 
Martin K. Petersen	Oracle Linux Engineering
Thread (1 message) 1 message, 1 author, last reply 2017-01-26
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help