Thread (44 messages) 44 messages, 14 authors, 2017-01-13

Re: [PATCH] uapi: use wildcards to list files

From: Nicolas Dichtel <hidden>
Date: 2017-01-04 09:03:46
Also in: alsa-devel, dri-devel, linux-arch, linux-fbdev, linux-media, linux-mmc, linux-nfs, linux-rdma, linux-spi, lkml, netdev, netfilter-devel

Le 03/01/2017 à 22:37, Arnd Bergmann a écrit :
On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote:
quoted
Regularly, when a new header is created in include/uapi/, the developer
forgets to add it in the corresponding Kbuild file. This error is usually
detected after the release is out.

In fact, all headers under include/uapi/ should be exported, so let's
use wildcards.
I think the idea makes a lot of sense: if a header is in uapi, we should
really export it. However, using a wildcard expression seems a bit
backwards here, I think we should make this implicit and not have the
Kbuild file at all.

The "header-y" syntax was originally added back when the uapi headers
were mixed with the internal headers in the same directory. After
David Howells introduced the separate directory for uapi, it has
become a bit redundant.
Ok, thank you for the explanation, I was wondering why those Kbuild files were
needed.
Can you try to modify scripts/Makefile.headersinst instead so we
can simply remove the Kbuild files entirely?
I will try something.


Regards,
Nicolas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help