Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments

[PATCH 00/60] block: support multipage bvec · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 21/60] bcache: comment on direct access to bvec table · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 22/60] block: comment on bio_alloc_pages() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 24/60] md: set NO_MP for request queue of md · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 29/60] dm: limit the max bio size as BIO_SP_MAX_SECTORS << SECTOR_SHIFT · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 39/60] bcache: debug: switch to bio_clone_sp() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 02/60] block drivers: convert to bio_init_with_vec_table() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 06/60] bcache: debug: avoid to access .bi_io_vec directly · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 07/60] dm: crypt: use bio_add_page() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 08/60] dm: use bvec iterator helpers to implement .get_page and .next_page · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Christoph Hellwig <hch@infradead.org> · 2016-10-31
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Ming Lei <tom.leiming@gmail.com> · 2016-10-31
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Kent Overstreet <hidden> · 2016-11-02
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Ming Lei <tom.leiming@gmail.com> · 2016-11-02
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Mike Snitzer <hidden> · 2016-11-02
Re: [PATCH 09/60] dm: dm.c: replace 'bio->bi_vcnt == 1' with !bio_multiple_segments · Ming Lei <tom.leiming@gmail.com> · 2016-11-02
[PATCH 30/60] bcache: set flag of QUEUE_FLAG_SPLIT_MP · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 57/60] bcache: convert to bio_for_each_segment_all_rd() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
[PATCH 58/60] dm-crypt: convert to bio_for_each_segment_all_rd() · Ming Lei <tom.leiming@gmail.com> · 2016-10-29
Re: [PATCH 00/60] block: support multipage bvec · Christoph Hellwig <hch@infradead.org> · 2016-10-31
Re: [PATCH 00/60] block: support multipage bvec · Ming Lei <tom.leiming@gmail.com> · 2016-10-31

From: Kent Overstreet <hidden>
Date: 2016-11-02 03:09:06
Also in: dm-devel, linux-block, linux-fsdevel, lkml

On Mon, Oct 31, 2016 at 08:29:01AM -0700, Christoph Hellwig wrote:

On Sat, Oct 29, 2016 at 04:08:08PM +0800, Ming Lei wrote:

quoted

Avoid to access .bi_vcnt directly, because it may be not what
the driver expected any more after supporting multipage bvec.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>

It would be really nice to have a comment in the code why it's
even checking for multiple segments.

Or ideally refactor the code to not care about multiple segments at all.

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help