Re: [PATCH] super1: make write_bitmap1 compatible with previous mdadm versions

From
Jes Sorensen <hidden>
Date
2016-10-19 15:21:31
Guoqing Jiang [off-list ref] writes:
For older mdadm version, v1.x metadata has different bitmap_offset,
we can't ensure all the bitmaps are on a 4K boundary since writing
4K for bitmap could corrupt the superblock, and Anthony reported
the bug about it at below link.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=837964

So let's check about the alignment for bitmap_offset before set
the boundary to 4096 unconditionally. Thanks for Neil's detailed
explanation.

Reported-by: Anthony DeRobertis <redacted>
Fixes: 95a05b37e8eb ("Create n bitmaps for clustered mode")
Cc: Neil Brown <redacted>
Signed-off-by: Guoqing Jiang <redacted>
---
 super1.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)
Applied!

Thanks,
Jes
Thread (1 message) 1 message, 1 author, last reply 2016-10-19
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help