Re: [PATCH] imsm: do not activate spares for uninitialized member arrays

From
Jes Sorensen <hidden>
Date
2016-09-15 16:16:35
Artur Paszkiewicz [off-list ref] writes:
This fixes some issues when a member array is created with "missing"
devices in a container that has more devices than used in the member
array.

Reported-by: Yi Zhang <redacted>
Signed-off-by: Artur Paszkiewicz <redacted>
---
 super-intel.c | 5 +++++
 1 file changed, 5 insertions(+)
Applied!

Thanks,
Jes
quoted hunk
diff --git a/super-intel.c b/super-intel.c
index 92817e9..032ef00 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7789,6 +7789,11 @@ static struct mdinfo *imsm_activate_spare(struct active_array *a,
 			IMSM_T_STATE_DEGRADED)
 		return NULL;
 
+	if (get_imsm_map(dev, MAP_0)->map_state == IMSM_T_STATE_UNINITIALIZED) {
+		dprintf("imsm: No spare activation allowed. Volume is not initialized.\n");
+		return NULL;
+	}
+
 	/*
 	 * If there are any failed disks check state of the other volume.
 	 * Block rebuild if the another one is failed until failed disks
Thread (1 message) 1 message, 1 author, last reply 2016-09-15
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help