Thread (1 message) 1 message, 1 author, 2016-06-14

Re: [PATCH 1/1] MDADM:Check mdinfo->reshape_active more times before calling Grow_continue

From: Jes Sorensen <hidden>
Date: 2016-06-14 18:34:09

Xiao Ni [off-list ref] writes:
Hi 

When reshaping a 3 drives raid5 to 4 drives raid5, there is a chance that
it can't start the reshape. If the disks are not enough to have spaces for
relocating the data_offset, it needs to call start_reshape and then run 
mdadm --grow --continue by systemd. But mdadm --grow --continue fails 
because it checkes that info->reshape_active is 0. 

The info->reshape_active is got from the superblock of underlying devices.
Function start_reshape write reshape to /sys/../sync_action. Before writing
latest superblock to underlying devices, mdadm --grow --continue is called.
There is a chance info->reshape_active is 0. We should wait for superblock
updating more time before calling Grow_continue.

Regards
Xiao
Hi Xiao,

Looks reasonable to retry before giving up.

Unfortunately your patch has some whitespace issues at the end, using
spaces instead of tabs, and lacks a signed-off-by line.

Would you mind fixing it up and resubmitting it?

Thanks,
Jes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help