Thread (4 messages) 4 messages, 3 authors, 2016-04-11

Re: dm: ioctl: use kvfree

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2016-04-11 16:10:17
Also in: dm-devel, lkml

On Monday 11 April 2016 08:47 PM, Mike Snitzer wrote:
On Mon, Apr 11 2016 at 11:14am -0400,
Sudip Mukherjee [off-list ref] wrote:
quoted
We can use kvfree() instead of calling kfree() and vfree() based on
if-else and param_flags. kvfree() will check the type of address and
will call the respective function to free it.
Additionally we can also remove the use of DM_PARAMS_KMALLOC and
DM_PARAMS_VMALLOC.

Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
Have you actually tested htis?  Last time I looked to do this it exposed
crashes.  I don't have time to dig into this again right now but this is
_not_ as simple as this patch implies.
No, it was just build tested. Is it possible to test it in qemu or kvm?

regards
sudip
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help