Re: [PATCH] Grow: analyse_change add notification about only 2-device can be convert from RAID1 to RAID5

From
Jes Sorensen <hidden>
Date
2016-03-11 17:41:44
Yi Zhang [off-list ref] writes:
Notify "Can only convert a 2-device array to RAID5" instead of
"Impossibly level change request for RAID1" when convert from
RAID1 to RAID5 if the disk num is not equal two like RAID4/5->RAID1
did.

Signed-off-by: Yi Zhang <redacted>
---
 Grow.c | 3 +++
 1 file changed, 3 insertions(+)
Applied!

Thanks,
Jes
quoted hunk
diff --git a/Grow.c b/Grow.c
index cf2750a..4e2fc08 100755
--- a/Grow.c
+++ b/Grow.c
@@ -1077,6 +1077,9 @@ char *analyse_change(char *devname, struct mdinfo *info, struct reshape *re)
 			re->level = 1;
 			return NULL;
 		}
+		if (info->array.raid_disks != 2 &&
+		    info->new_level == 5)
+			return "Can only convert a 2-device array to RAID5";
 		if (info->array.raid_disks == 2 &&
 		    info->new_level == 5) {
Thread (1 message) 1 message, 1 author, last reply 2016-03-11
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help