Re: [PATCH 3/3] raid5: allow r5l_io_unit allocations to fail
From: Shaohua Li <hidden>
Date: 2015-12-18 23:07:11
From: Shaohua Li <hidden>
Date: 2015-12-18 23:07:11
On Fri, Dec 18, 2015 at 12:25:35PM +0100, Christoph Hellwig wrote:
[can you trim your replies please? I had to trim almost 150 lines of junk before getting to your reply!]quoted
quoted
spin_unlock_irqrestore(&log->io_list_lock, flags); or is that too simplistic?maybe add a new list and run the list at the begining of r5l_do_reclaim().What's the advantage of another list?
I mean simply waking up reclaim thread doesn't work as r5l_do_reclaim() will return if reclaimable == 0. There is no guarantee reclaimable space is available in the allocation failure. So we'd better move the retry at the begining of r5l_do_reclaim(). If yes, we can't reuse the no_space_stripes list. Thanks, Shaohua