Re: [PATCH 2/2] raid5-cache: add journal hot add/remove support
From: NeilBrown <hidden>
Date: 2015-12-16 22:50:34
Attachments
- signature.asc [application/pgp-signature] 818 bytes
From: NeilBrown <hidden>
Date: 2015-12-16 22:50:34
On Thu, Dec 17 2015, Shaohua Li wrote:
Add support for journal disk hot add/remove. Mostly trival checks in md part. The raid5 part is a little tricky. For hot-remove, we can't wait pending write as it's called from raid5d. The wait will cause deadlock. We simplily fail the hot-remove. A hot-remove retry can success eventually since if journal disk is faulty all pending write will be failed and finish. For hot-add, since an array supporting journal but without journal disk will be marked read-only, we are safe to hot add journal without stopping IO (should be read IO, while journal only handles write IO).
This and previous patch both applied - thanks. (will push things out to for-next next later today I hope) NeilBrown