Re: [PATCH 2/2] raid5-cache: use a mempool for the metadata block
From: NeilBrown <hidden>
Date: 2015-12-08 23:27:25
On Thu, Dec 03 2015, Christoph Hellwig wrote:
+ error: md_unregister_thread(&log->reclaim_thread); reclaim_thread: + mempool_destroy(log->meta_pool); +out_mempool: bioset_free(log->bs); io_bs:
These cascading goto labels always bother me.
As mempool_destroy accepts NULL, we don't need "out_mempool", we can
just "goto reclaim_thread", or even "goto error" as md_unregsiter_thread
copes with NULL too.
If we use:
if (log->bs)
bioset_free(log->bs);
or modified bioset_free, we could just have a single 'error' label...
But that is just cosmetic. I like the patch once we agree on value for
R5L_POOL_SIZE.
Thanks,
NeilBrown
quoted hunk ↗ jump to hunk
kmem_cache_destroy(log->io_kc);@@ -1192,6 +1201,7 @@ io_kc: void r5l_exit_log(struct r5l_log *log) { md_unregister_thread(&log->reclaim_thread); + mempool_destroy(log->meta_pool); bioset_free(log->bs); kmem_cache_destroy(log->io_kc); kfree(log);-- 1.9.1
Attachments
- signature.asc [application/pgp-signature] 818 bytes