On Tue, Dec 8, 2015 at 1:08 PM, Verma, Vishal L
[off-list ref] wrote:

On Wed, 2015-12-09 at 08:03 +1100, NeilBrown wrote:

quoted

On Sat, Dec 05 2015, Verma, Vishal L wrote:

quoted

quoted

quoted

+int badblocks_clear(struct badblocks *bb, sector_t s, int
sectors)
+{

[...]

quoted

+#define DO_DEBUG 1

Why have this at all if it's unconditionally defined and always
set.

Neil - any reason or anything you had in mind for this? Or is it
just an
artifact and can be removed.

Like the comment says:

      /* Allow clearing via sysfs *only* for testing/debugging.
       * Normally only a successful write may clear a badblock
       */

The DO_DEBUG define and ifdefs are documentation identifying bits of
code that should be removed when it all seems to be working.
Maybe now is a good time to remove that code.

Hm, I think it would be nice to continue to have the ability to clear
badblocks using sysfs at least for a while more, as we test the various
error handling paths for NVDIMMS (Dan, thoughts?).

We could either remove it later or (I'm leaning towards) make it a
config option similar to FAIL_MAKE_REQUEST and friends..

"later" as in before v4.5-rc1?  We can always carry this debug feature
locally for testing.  We don't want userspace growing ABI attachments
to this capability now that it's more than just md tooling that will
see this.