Thread (8 messages) 8 messages, 3 authors, 2015-08-04

Re: [PATCH 1/2] Safeguard against writing to an active device of another node

From: Guoqing Jiang <hidden>
Date: 2015-08-04 10:23:34

Adam Goryachev wrote:
On 04/08/15 20:05, Guoqing Jiang wrote:
  
quoted
Hi Goldwyn,

Thanks for review.

Goldwyn Rodrigues wrote:
    
quoted
quoted
+    set_dlm_hookers(); /* get dlm funcs from libdlm_lt.so.3 */
+
        
Universal Comment: Let call it set_dlm_hooks as opposed to hookers.

      
Not sure I understood correctly, the second patch used set_hookers to
call set_dlm_hookers.
    
I think Neil meant to ask you to please do a global s/hookers/hooks/
because hooker has a particular meaning in english which is different to
what you intended.
http://www.urbandictionary.com/define.php?term=hooker

Hope that helps.
  
Got it, thanks for the website, will change it.

Thanks,
Guoqing

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help