On Thu, Jun 11, 2015 at 09:53:27AM +0200, Christoph Hellwig wrote:

On Wed, Jun 10, 2015 at 11:26:49AM -0400, Mike Snitzer wrote:

quoted

Unfortunately by dropping the original error (e.g. -EREMOTEIO) on the
floor (in the 'if (endio) {' branch) you're breaking the REQ_WRITE_SAME
check.

I think this also happens in the old code before my patch, e.g.:

Ok, after and audit of the instance I noticed that returning 0 from
->end_io even if an error is passed is a valid calling convention,
and with that the below analysis is invalid.  I'll take it back and
will do the simplest possible conversion for now and return my
attention to sorting out this mess later.