Thread (11 messages) 11 messages, 3 authors, 2015-05-27

Re: [PATCH v4 06/11] md/raid5: get rid of bio_fits_rdev()

From: Ming Lin <mlin@kernel.org>
Date: 2015-05-26 14:33:52
Also in: lkml

On Mon, May 25, 2015 at 7:17 AM, Christoph Hellwig [off-list ref] wrote:
On Mon, May 25, 2015 at 05:54:14PM +1000, NeilBrown wrote:
quoted
Did I write that?  I guess I did :-(
I meant *after*.   Don't get rid of bio_fits_rdev until split_bio is in
chunk_aligned_read().
I suspect the whole series could use some reordering.
Nice reordering.
I'll do this.

Thanks.
patch 1:

 add ->bio_split and blk_queue_split

patch 2..n:

 one for each non-trivial driver that implements ->merge_bvec_fn to
 remove it and instead split bios in ->make_request.  The md patch
 to do the right thing in chunk_aligned_read goes into the general
 md patch here.  The bcache patch also goes into this series.

patch n+1:

 - add blk_queue_split calls for remaining trivial drivers

patch n+2:

 - remove ->merge_bvec_fn and checking of max_sectors a for all
   drivers, simplify bio_add_page

patch n+2:

 - remove splitting in blkdev_issue_discard

patch n+3

 - remove bio_fits_rdev

patch n+4

 - remove bio_get_nr_vecs

patch n+4

 - use bio_add_page

patch n+5

 - update documentation
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help