Re: [PATCH] Grow: Do not use grow-continue unit file if reshape is starting
From: NeilBrown <hidden>
Date: 2014-07-07 01:06:13
On Fri, 4 Jul 2014 08:59:00 +0000 "Baldysiak, Pawel" [off-list ref] wrote:
Mdadm should use mdadm-grow-continue unit file only if reshape is going to be continued. Otherwise, array specific reshape with IMSM metadata will fail to start, due to missing information about ongoing migration - grow-continue will try to start again the reshape process.
I don't think I agree. I think mdadm should always use mdadm-grow-continue unit file if it is available. Please explain in more detail what problem you are seeing. NeilBrown
quoted hunk ↗ jump to hunk
Signed-off-by: Pawel Baldysiak <redacted> --- Grow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/Grow.c b/Grow.c index a2f4f14..0cd9442 100644 --- a/Grow.c +++ b/Grow.c@@ -3272,7 +3272,7 @@ started: return 1; } - if (!forked && !check_env("MDADM_NO_SYSTEMCTL")) + if (restart && !forked && !check_env("MDADM_NO_SYSTEMCTL")) if (continue_via_systemd(container ?: sra->sys_name)) { free(fdlist); free(offsets);
Attachments
- signature.asc [application/pgp-signature] 828 bytes