Re: [PATCH 1/2] md: Add configurability for consistency check feature
From: NeilBrown <hidden>
Date: 2014-03-17 22:55:09
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 828 bytes
From: NeilBrown <hidden>
Date: 2014-03-17 22:55:09
Also in:
lkml
On Mon, 17 Mar 2014 16:00:04 +0100 Ralph Mueck [off-list ref] wrote:
This patch adds sysfs configurability for the md level-1 RAID consistency check. The feature introduces a new attribute in sysfs named "safe_read". To toggle consistency checks on/off, simply echo safe_read in /sys/block/md*/md/safe_read. Signed-off-by: Ralph Mueck <redacted> Signed-off-by: Matthias Oefelein <redacted> --- drivers/md/md.c | 27 +++++++++++++++++++++++++++ drivers/md/md.h | 3 +++ 2 files changed, 30 insertions(+)diff --git a/drivers/md/md.c b/drivers/md/md.c index 4ad5cc4..5cc9a00 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c@@ -4652,6 +4652,32 @@ static struct md_sysfs_entry md_array_size = __ATTR(array_size, S_IRUGO|S_IWUSR, array_size_show, array_size_store); +static ssize_t +safe_read_show(struct mddev *mddev, char *page) +{ + if(mddev->safe_read) + return sprintf(page, "enabled\n"); + else + return sprintf(page, "disabled\n"); +} + +static ssize_t +safe_read_store(struct mddev *mddev, const char *buf, size_t len) +{ + if(mddev->pers->level != 1) { + printk(KERN_NOTICE "RAID level not supported!\n"); + return len; + } + if (strncmp(buf, "safe_read", 9) == 0) { + mddev->safe_read = !mddev->safe_read; + } + return len; +} +
So let me get this straight.... There is a sysfs file called "safe_read". When you read from that file it reports either "enabled" or "disabled". However you cannot write "enabled" or "disabled" to the file. Rather you write "safe_read". And when you do, it toggles the status. Seriously? Any chance you could use device_show_bool / device_store_bool ?? NeilBrown