Thread (5 messages) 5 messages, 2 authors, 2013-07-26

Re: mdadm -Db switches array to write-pending?!

From: NeilBrown <hidden>
Date: 2013-07-26 21:58:10

On Fri, 26 Jul 2013 20:01:54 +0200 Martin Wilck [off-list ref] wrote:
Hi Neil,

On 07/17/2013 10:19 PM, Martin Wilck wrote:
quoted
On 07/15/2013 07:18 AM, NeilBrown wrote:
quoted
Probably the  best thing to do is:
diff --git a/drivers/md/md.c b/drivers/md/md.c
index d059af5..b19a1c8 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5629,10 +5629,7 @@ static int get_bitmap_file(struct mddev * mddev, void __user * arg)
 	char *ptr, *buf = NULL;
 	int err = -ENOMEM;
 
-	if (md_allow_write(mddev))
-		file = kmalloc(sizeof(*file), GFP_NOIO);
-	else
-		file = kmalloc(sizeof(*file), GFP_KERNEL);
+	file = kmalloc(sizeof(*file), GFP_NOIO);
 
 	if (!file)
 		goto out;

A failure here is not likely and not catastrophic.

Does it fix the situation for you?
Yes it does.
Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Any particular reason why you haven't applied this patch in your git
tree http://git.neil.brown.name/?p=md.git;a=summary yet?
Hi Martin,
 you need to look in the for-next branch.
http://git.neil.brown.name/?p=md.git;a=shortlog;h=refs/heads/for-next

NeilBrown

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help