Re: [PATCH 3/3] execl() only returns in case of error
From: NeilBrown <hidden>
Date: 2013-01-22 05:48:09
On Mon, 21 Jan 2013 14:22:58 +0100 Jes.Sorensen@redhat.com wrote:
quoted hunk ↗ jump to hunk
From: Jes Sorensen <redacted> In case exec fails, fall through and print warning rather than just calling exit(1) silently. Signed-off-by: Jes Sorensen <redacted> --- util.c | 1 - 1 file changed, 1 deletion(-)diff --git a/util.c b/util.c index 500b2bd..68fd27e 100644 --- a/util.c +++ b/util.c@@ -1705,7 +1705,6 @@ int start_mdmon(int devnum) } } } - exit(1); case -1: pr_err("cannot run mdmon. " "Array remains readonly\n"); return -1;
??? Print the warning, and (still in the child) return to whoever called start_mdmon()? Not a good idea. If we want an error when mdmon fails (might be a good idea) we should print it after the 'wait' returns an error, not in the child. Thanks, NeilBrown
Attachments
- signature.asc [application/pgp-signature] 828 bytes