Thread (4 messages) 4 messages, 3 authors, 2012-11-15

Re: [PATCH 1/3] md:Add a func 'dm_md_stop' for dm-raid to clear up md resources.

flat view

From: Mike Snitzer <hidden>
Date: 2012-11-15 13:52:41
Also in: dm-devel

On Thu, Nov 15 2012 at  6:51am -0500,
majianpeng [off-list ref] wrote:
quoted
On Thu, Nov 15, 2012 at 04:46:59PM +0800, majianpeng wrote:
quoted
So add a func dm_md_stop to clear up resource.
quoted
+++ b/drivers/md/md.c
quoted
+void dm_md_stop(struct mddev *mddev)
+{
+	md_stop(mddev);
+	bitmap_destroy(mddev);
+	if (mddev->bio_set)
+		bioset_free(mddev->bio_set);
+}
+EXPORT_SYMBOL_GPL(dm_md_stop);
Let's not put a function with a dm_ prefix in an md file?

Alasdair
Can you give me a hint? My thought is this func only by dm to call and there was a md_stop already?
I firstly want to add those statements in dm driver like md_stop rather than a func include those.
But i think dm don't know to much.
Nmae it mddev_stop_and_cleanup?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help