On 03/05/2012 06:27 PM, NeilBrown wrote:

So it is still called fsync_bdev and invalidate_bdev as long as the
ioctl function for the underlying disk returns -EINVAL or -ENOTTY.

The function that shows that warning is scsi_verify_blk_ioctl in 
block/scsi_ioctl.c The worst it can do is return -ENOTTY, and that
is safe.

So the warning is bogus, the code still works.

We should whitelist ioctls if they are legitimately used and harmless.
 Do we have a specific list?

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.