Re: [patch 0/7] Add TRIM support for raid linear/0/1/10
From: Shaohua Li <shli@kernel.org>
Date: 2012-03-18 02:03:34
Also in:
lkml
2012/3/18 Mark Lord [off-list ref]:
On 12-03-13 10:47 PM, Shaohua Li wrote:quoted
On 3/14/12 10:24 AM, NeilBrown wrote:quoted
On Mon, 12 Mar 2012 11:04:12 +0800 Shaohua Li [off-list ref] wrote:..quoted
quoted
Also I wonder about handling failure in RAID1. I think the code will currently treat it like a write error, and maybe record a bad block (then fail the device is writing the badblock record fails). Is that what were want?Mainly to simplify the code. And I thought a normal discard should not fail. If it fails, something is wrong, marked it as badblock maybe not bad.That sounds like a VERY bad idea. Failures happen for lots of reasons, but generic comm errors are not an excuse to suddenly mark sectors as bad.
Not sure if I got it, but we treat discard similar like write. Did you mean discard request error is common?