On Wed,  2 Nov 2011 15:42:05 +0100 Jes.Sorensen@redhat.com wrote:

From: Jes Sorensen <redacted>

Hi,

As promised, here is another batch of fixes for small memory leaks,
use of invalid file descriptors and NULL pointer dereferences.

The coverity output is starting to look a lot better by now :)

Cheers,
Jes

Thanks.

Jes Sorensen (12):
  mdadm: add missing break for UpdateSubarray

This was wasn't correct.  The code was actually doing  the right thing.
But I agree that it looked wrong so I rearranged the code a bit to make it
(hopefully) less confusing.

All the rest applied.

thanks,
NeilBrown

  ping_monitor(): check file descriptor is valid before using and
    closing it
  mdstat_read(): Check return value of dup() before using file
    descriptor
  get_component_size(): Check read() return value for error before
    using it
  array_try_spare(): open_dev() returns -1 on error, not zero
  disk_init_and_add(): Fail if opening sysfs file descriptors fail
  close_aa(): Verify file descriptors are valid before trying to close
    them
  ahci_enumerate_ports(): Don't close fd that failed to open
  unblock_monitor(): Check sra is valid before dereferencing
  Manage_ro(): Check pointer rather than dereferencing it
  fd2devname(): Don't dereference NULL pointer
  match_metadata_desc(): Fix memory leak

 Incremental.c |    2 +-
 Manage.c      |    2 +-
 managemon.c   |   21 ++++++++++++++++-----
 mdadm.c       |    1 +
 mdstat.c      |    7 ++++++-
 msg.c         |   11 +++++++++--
 super-intel.c |    8 +++++---
 super-mbr.c   |    7 ++++---
 sysfs.c       |    2 +-
 9 files changed, 44 insertions(+), 17 deletions(-)